Skip to content

fix: make respect jsonpath criteria compliant with rfc9535#2745

Draft
DmitryAnansky wants to merge 4 commits intomainfrom
fix/make-jsonpath-criteria-complient-with-rfc9535
Draft

fix: make respect jsonpath criteria compliant with rfc9535#2745
DmitryAnansky wants to merge 4 commits intomainfrom
fix/make-jsonpath-criteria-complient-with-rfc9535

Conversation

@DmitryAnansky
Copy link
Copy Markdown
Contributor

@DmitryAnansky DmitryAnansky commented Apr 15, 2026

What/Why/How?

  • Made respect jsonpath criteria complient with rfc9535.
  • Remove custom handling implementation.

Reference

Testing

Screenshots (optional)

Check yourself

  • This PR follows the contributing guide
  • All new/updated code is covered by tests
  • Core code changed? - Tested with other Redocly products (internal contributions only)
  • New package installed? - Tested in different environments (browser/node)
  • Documentation update has been considered

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

Note

Medium Risk
Changes core success-criteria evaluation semantics for jsonpath conditions (including removing prior custom parsing/eval behavior), which may break existing workflows relying on legacy expressions.

Overview
Respect’s JSONPath success criteria now evaluate using RFC 9535 JSONPath queries (via jsonpath-rfc9535) instead of the previous custom expression parsing and Function-based evaluation.

Test coverage, snapshots, and sample Arazzo workflows are updated to use RFC 9535-compatible filter-style conditions (e.g. "$[?@.name == '...']" and length(...)) and a changeset bumps @redocly/respect-core as a patch release.

Reviewed by Cursor Bugbot for commit 4acb9e3. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 15, 2026

🦋 Changeset detected

Latest commit: 4acb9e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@redocly/respect-core Patch
@redocly/cli Patch
@redocly/openapi-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DmitryAnansky DmitryAnansky force-pushed the fix/make-jsonpath-criteria-complient-with-rfc9535 branch from 885cd8f to f621381 Compare April 15, 2026 12:56
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

CLI Version Mean Time ± Std Dev (s) Relative Performance (Lower is Faster)
cli-latest 3.168s ± 0.037s ▓ 1.00x
cli-next 3.167s ± 0.032s ▓ 1.00x (Fastest)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 79.77% (🎯 79%) 6625 / 8305
🔵 Statements 79.24% (🎯 79%) 6867 / 8666
🔵 Functions 83.1% (🎯 82%) 1358 / 1634
🔵 Branches 71.49% (🎯 71%) 4529 / 6335
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/respect-core/src/modules/flow-runner/success-criteria/evaluate-jsonpath-condition.ts 75% 100% 100% 75% 8
Generated in workflow #9466 for commit 4acb9e3 by the Vitest Coverage Report Action

@DmitryAnansky DmitryAnansky self-assigned this Apr 15, 2026
@DmitryAnansky DmitryAnansky changed the title fix: make jsonpath criteria complient with rfc9535 fix: make respect jsonpath criteria compliant with rfc9535 Apr 15, 2026
@DmitryAnansky DmitryAnansky marked this pull request as ready for review April 15, 2026 15:01
@DmitryAnansky DmitryAnansky requested review from a team as code owners April 15, 2026 15:01
Comment thread .changeset/honest-crabs-rhyme.md Outdated
Copy link
Copy Markdown
Contributor

@kanoru3101 kanoru3101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@DmitryAnansky DmitryAnansky added the snapshot Create experimental release PR label Apr 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

📦 A new experimental 🧪 version v0.0.0-snapshot.1776345459 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/cli@0.0.0-snapshot.1776345459
# or
npm install @redocly/openapi-core@0.0.0-snapshot.1776345459
# or
npm install @redocly/respect-core@0.0.0-snapshot.1776345459

⚠️ Note: This is a development build and may contain unstable features.

@DmitryAnansky DmitryAnansky marked this pull request as draft April 16, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

snapshot Create experimental release PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants